Support unboxing of mojo parameters. #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… since Java reflection does so anyway.
| * | ||
| * See the Java Language Specification, Java SE 7 Edition, §4.12.5 "Initial Values of Variables". | ||
| */ | ||
| private val boxedDefaultValues = scala.collection.immutable.Map[Class[_], AnyRef]( |
There was a problem hiding this comment.
BTW - null.asInstanceOf[PrimitiveType] in scala gives you the default, although it's kind of hacky. This is way better.
|
LGTM. Thanks for the fix! |
jsuereth
added a commit
that referenced
this pull request
Apr 2, 2013
…arams Support unboxing of mojo parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the scala-mojo-support code throws an exception if it encounters a mojo parameter with a primitive type.
This change adds support for unboxing, by simply stripping out the offending type check. I did this because:
This change also adds handling for Maven passing a
nullvalue to a parameter with a primitive type. I don't think it will ever do this, but in case it does, scala-mojo-support will now react by resetting thevarto the default value for its primitive type (0 for integers, floats, and characters, andfalsefor Boolean).