Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: find keys in arguments of pipes #114

Closed
1 task done
Serrulien opened this issue Nov 7, 2021 · 1 comment
Closed
1 task done

Feature: find keys in arguments of pipes #114

Serrulien opened this issue Nov 7, 2021 · 1 comment

Comments

@Serrulien
Copy link
Contributor

Serrulien commented Nov 7, 2021

Is there an existing issue for this?

No

  • I have searched the existing issues

Is your feature request related to a problem? Please describe

I frequently use the transloco pipe inside arguments of another pipe:

{{ var | pipe : ( 'key' | transloco ) }}
{{ var | pipe : ({ foo: 'key' | transloco }) | another }}

In v3.1.1, translation keys in pipes' args are not detected by the keys manager. I would like them to be detected.

I would like to make a pull request for this feature

Yes 🚀

@shaharkazaz
Copy link
Collaborator

Waiting to see your PR for it 😉

Serrulien added a commit to Serrulien/transloco-keys-manager that referenced this issue Nov 7, 2021
sirrocco pushed a commit to sirrocco/transloco-keys-manager that referenced this issue Jan 4, 2022
* feat: 🎸 detect keys in pipes args

✅ Closes: jsverse#114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants