Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only seach ts files for scopes #164

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

bkleiner
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Fix scopes extraction in cases where webpack emits a folder.

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

It appears in some situations webpack emits folders in the files array.
The files array is passed directly to the the updateScopesMap function.
This leads webpack to crash when it's trying to be read.

Error: EISDIR: illegal operation on a directory, read

Issue Number: N/A

What is the new behavior?

Only *.ts files are passed to the updateScopesMap function as files.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@stackblitz
Copy link

stackblitz bot commented Jun 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@shaharkazaz shaharkazaz merged commit d3e583f into jsverse:master Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants