Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added loader #105

Merged
merged 6 commits into from
Oct 20, 2022
Merged

added loader #105

merged 6 commits into from
Oct 20, 2022

Conversation

kuldeepmangla
Copy link
Contributor

PR Title

The purpose of this Pull Request is to fix #

Description

How you solved

Screenshots

Checklist

  • I have Made this contribution as per the CONTRIBUTING guide in this repo
  • I have tested in local Environment.
  • I have made the fix as per issue converstaion
  • I have starred the repository ⭐

@vercel
Copy link

vercel bot commented Oct 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tailwindcss-ui-components ✅ Ready (Inspect) Visit Preview Oct 20, 2022 at 2:01PM (UTC)

@kuldeepmangla
Copy link
Contributor Author

@jsvigneshkanna please review the PR

@jsvigneshkanna
Copy link
Owner

@kuldeepmangla , great

Can you add these loader in each codepen pages like button/forms

@kuldeepmangla
Copy link
Contributor Author

@jsvigneshkanna I have made the require changes pls review it

@jsvigneshkanna
Copy link
Owner

@kuldeepmangla ,sorry but we can keep loader for homepage alone
As loader in codepen page not working as expected

@jsvigneshkanna
Copy link
Owner

Can revert those files and keep only for homepage

Appreciate that!

@kuldeepmangla
Copy link
Contributor Author

@jsvigneshkanna I have revert the changes

@jsvigneshkanna
Copy link
Owner

Great @kuldeepmangla

@jsvigneshkanna jsvigneshkanna added the hacktoberfest-accepted Issue fix accepted for hacktoberfest label Oct 20, 2022
@kuldeepmangla
Copy link
Contributor Author

@jsvigneshkanna can you merge this PR

@jsvigneshkanna
Copy link
Owner

Yes @kuldeepmangla , tweaking the code a bit

BTW, check other issues too!

@jsvigneshkanna
Copy link
Owner

@kuldeepmangla ,

resolved the conflicts, merging your changes

Please check other issues to contribute on!

@jsvigneshkanna jsvigneshkanna merged commit 089d6cf into jsvigneshkanna:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Issue fix accepted for hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants