-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header UI fixed on screen width greater than 640px and less than 900px #243
Header UI fixed on screen width greater than 640px and less than 900px #243
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jsvigneshkanna Kindly review my PR, and merge it. |
@HammadKhaan , |
For this type of issue, we could go with plain CSS |
Sure @jsvigneshkanna. I am on it. I was hesitant use plain CSS. xD But I will take care of it now. |
Great, BTW don't rely on single CSS framework as it backfires as sometime 🤣 It's better to have specific plain CSS styling for navbars alone than reflecting another component by modifying the tailwind config |
@jsvigneshkanna Check now. |
@HammadKhaan , can you try vercel preview link I couldnt open hamburger menu in Ipad viewport(is it just for me?) |
Working fine on my local environment, causing issue on vercel preview. I'll look into it. |
Sure @HammadKhaan , please check and let me know if you are sure to merge this change |
@jsvigneshkanna Check now, vercel preview also working fine. Merge it, if it is all okay on your end. |
Sure @HammadKhaan , willl check in some time and let you know. |
@HammadKhaan Perfect working |
PR Title
Header UI fixed on screen width greater than 640px and less than 900px
The purpose of this Pull Request is to fix # 242
Description
When your screen width is less than 900px, a hamburger icon will be visible instead of whole navbar item contents, on clicking that hamburger icon then you will see the remaining content of navbar.
How you solved
Using media queries and TailwindCSS.
Screenshots
Checklist