Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create contributors page #245

Merged
merged 10 commits into from
Oct 25, 2022

Conversation

AnnieDebbie
Copy link
Contributor

PR Title

This PR addresses issue #182
It creates a page to display the repository's contributors

Description

I created a new page named "contributors" with a navbar, contributors component and footer.

How you solved

I created two components—one for each contributor and another for all contributors. The contributor component hits github's Users API to get social media URLs. The contributors component encapsulates the contributor component, passes down repository contributors and displays all contributors. There's a display for mobile and one for viewports > 768px

Screenshots

Checklist

  • I have Made this contribution as per the CONTRIBUTING guide in this repo
  • I have tested in local Environment.
  • I have made the fix as per issue converstaion
  • I have starred the repository ⭐

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tailwindcss-ui-components ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 4:15PM (UTC)

@jsvigneshkanna
Copy link
Owner

Great @AnnieDebbie ,
Quick request,

  1. In new page, the card container isn't centered though (we need to center it to the page and have mx-40 which brings the container to navbars margins horizontally and mx-4 in mobile screens):

image

  1. And we can make border color to navbar's orange and add some radius (border-2xl will suffice)

  2. And also we can remove the contributors section in about us page and add a link to new page there like ("check our cool contributors here ->")

@AnnieDebbie
Copy link
Contributor Author

Okay, got it

@jsvigneshkanna
Copy link
Owner

Great! @AnnieDebbie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants