Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Navbar Hover Clickable #248

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

Athi223
Copy link
Contributor

@Athi223 Athi223 commented Oct 25, 2022

PR Title

The purpose of this Pull Request is to fix #247

Description

This PR fixes the issue of Navbar Links' Hover background not being Clickable. Now we can click on the Hover Background to navigate to a link as well

How you solved

Added the div with class nav-links inside the Link component (was initially outside the Link component). i.e. made the parent component as a child of its original child component

Screenshots

image
("Before" images already posted in issue)

Checklist

  • I have Made this contribution as per the CONTRIBUTING guide in this repo
  • I have tested in local Environment.
  • I have made the fix as per issue conversation
  • I have starred the repository ⭐

@vercel
Copy link

vercel bot commented Oct 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tailwindcss-ui-components ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 7:39PM (UTC)

@jsvigneshkanna
Copy link
Owner

Great @Athi223
Hope for more contributions from you

@jsvigneshkanna jsvigneshkanna merged commit 72f752b into jsvigneshkanna:master Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Navbar Links are not clickable via their hover backgrounds
2 participants