Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create MANIFEST.in #2

Merged
merged 1 commit into from Apr 8, 2017
Merged

Create MANIFEST.in #2

merged 1 commit into from Apr 8, 2017

Conversation

pmlandwehr
Copy link
Contributor

Hey-lo,

I'm building a version of weightedcalcs using conda for conda-forge. When possible, we try to include a link to the license file in the meta.yaml specification for the build; doing so requires the license be indexed in an explicit MANIFEST.in file so that it gets included in the source distribution.

This pull should add a MANIFEST.in that guarantees the license gets included, along with the change log and the Readme.

@coveralls
Copy link

coveralls commented Apr 5, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 996a280 on pmlandwehr:patch-1 into 5cc7dbb on jsvine:master.

@jsvine
Copy link
Owner

jsvine commented Apr 6, 2017

Hi Peter, and thanks. I'm not terribly familiar with conda-forge. Is there a way to achieve your goal here via setup.py? Would love to minimize the number of configuration files.

@pmlandwehr
Copy link
Contributor Author

pmlandwehr commented Apr 6, 2017 via email

@pmlandwehr
Copy link
Contributor Author

The above said, let me also note that for the moment we're bundling a copy of the LICENSE, which works ok - though if you update the license we'll need to update the copy.

@jsvine
Copy link
Owner

jsvine commented Apr 7, 2017

Ah, great. I think this commit/PR should add what you're looking for: https://github.com/jsvine/weightedcalcs/pull/3/files

Does it? If so, I'll merge into master and push to PyPi.

@pmlandwehr
Copy link
Contributor Author

To my eyes that looks just fine as a fix, but obviously I'd recommend using a local build to test. If there's a LICENSE.txt in the generated tarball then that's just perfect.

@jsvine
Copy link
Owner

jsvine commented Apr 8, 2017

Hmm, looks like my solution didn't work, and won't without some convoluted-ness. Merging your PR, and then will push to PyPi. Thanks!

@jsvine jsvine merged commit bb6c33a into jsvine:master Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants