Handle the type={truthy} case in jsx

jsx-eslint · Oct 15, 2018 · 46e9abd · 46e9abd
1 parent c538d35
commit 46e9abd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/__tests__/src/util/implicitRoles/input-test.js b/__tests__/src/util/implicitRoles/input-test.js
@@ -29,4 +29,7 @@ describe('isAbstractRole', () => {
   it('works for the default case', () => {
     expect(getImplicitRoleForInput([JSXAttributeMock('type', '')])).toBe('textbox');
   });
+  it('works for the true case', () => {
+    expect(getImplicitRoleForInput([JSXAttributeMock('type', true)])).toBe('textbox');
+  });
 });
diff --git a/__tests__/src/util/implicitRoles/menuitem-test.js b/__tests__/src/util/implicitRoles/menuitem-test.js
@@ -16,4 +16,7 @@ describe('isAbstractRole', () => {
   it('works for non-toolbars', () => {
     expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', '')])).toBe('');
   });
+  it('works for the true case', () => {
+    expect(getImplicitRoleForMenuitem([JSXAttributeMock('type', true)])).toBe('');
+  });
 });
diff --git a/src/util/implicitRoles/input.js b/src/util/implicitRoles/input.js
@@ -9,7 +9,7 @@ export default function getImplicitRoleForInput(attributes) {
   if (type) {
     const value = getLiteralPropValue(type) || '';
 
-    switch (value.toUpperCase()) {
+    switch (typeof value === 'string' && value.toUpperCase()) {
       case 'BUTTON':
       case 'IMAGE':
       case 'RESET':

diff --git a/src/util/implicitRoles/menuitem.js b/src/util/implicitRoles/menuitem.js
@@ -9,7 +9,7 @@ export default function getImplicitRoleForMenuitem(attributes) {
   if (type) {
     const value = getLiteralPropValue(type) || '';
 
-    switch (value.toUpperCase()) {
+    switch (typeof value === 'string' && value.toUpperCase()) {
       case 'COMMAND':
         return 'menuitem';
       case 'CHECKBOX':