Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsx-a11y/no-interactive-element-to-noninteractive-role for canvas #648

Closed
markwoon opened this issue Nov 17, 2019 · 2 comments · Fixed by #796
Closed

jsx-a11y/no-interactive-element-to-noninteractive-role for canvas #648

markwoon opened this issue Nov 17, 2019 · 2 comments · Fixed by #796

Comments

@markwoon
Copy link
Contributor

This rule currently does not allow canvas elements to be given the img role even though that's the recommendation (e.g. http://pauljadam.com/demos/canvas.html).

Would it be possible to add it as a standard exception the way tr is right now?
@SudharsanSukumar
Copy link

Can we get some traction on this?

@ljharb
Copy link
Member

ljharb commented May 25, 2021

@SudharsanSukumar PRs are welcome

markwoon added a commit to markwoon/eslint-plugin-jsx-a11y that referenced this issue May 26, 2021
@markwoon
Support img role for canvas. Fix for jsx-eslint#648.
55e5c11
@ljharb ljharb mentioned this issue May 26, 2021
Merged
@huyenltnguyen huyenltnguyen mentioned this issue Jun 12, 2021
Closed
jessebeach added a commit that referenced this issue Jun 13, 2021
@jessebeach
Merge pull request #796 from markwoon/master
2ebb1ad 
Support img role for canvas. Fix for #648.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support img role for canvas. Fix for #648. markwoon/eslint-plugin-jsx-a11y
3 participants
@ljharb @markwoon @SudharsanSukumar