Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepend slash to top level dirs in npmignore #279

Merged
merged 1 commit into from Jun 29, 2017

Conversation

jessebeach
Copy link
Collaborator

@jessebeach jessebeach commented Jun 29, 2017

"Lines prefixed with / will only match entries starting from the current location of that .npmignore. For example, /foo will match foo and not lib/foo, but foo will match both."

from https://github.com/npm/npm/wiki/Files-and-Ignores

I realized that the dirs in .npmignore should be prepended with / to indicate that they are top-level.

I noticed that the src subdir in __tests__ was missing in the package. This change brings those back. npm pack produces:

__mocks__/
__tests__/
.babelrc
.eslintignore
.eslintrc
.npmignore
CHANGELOG.md
docs/
lib/
LICENSE.md
package.json
README.md
scripts/

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage remained the same at 99.57% when pulling 04a41b1 on jessebeach:fix-npmignore into 71ce135 on evcohen:master.

Copy link
Contributor

@beefancohen beefancohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@beefancohen beefancohen merged commit 1325369 into jsx-eslint:master Jun 29, 2017
@beefancohen
Copy link
Contributor

v6.0.2 published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants