Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in recommended config: onclick-has-focus #43

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Fix typo in recommended config: onclick-has-focus #43

merged 1 commit into from
Apr 26, 2016

Conversation

YellowKirby
Copy link
Contributor

I was trying to set up an eslintrc extending the recommended rules for jsx-a11y:

"extends": ["eslint:recommended", "plugin:react/recommended", "plugin:jsx-a11y/recommended"],
...
"plugins": [
    "react",
    "jsx-a11y"
]

And got a whole bunch of:

1:1  error  Definition for rule 'jsx-a11y/onclick-hs-focus' was not found  jsx-a11y/onclick-hs-focus

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.055% when pulling 6ed412a on YellowKirby:fix-typo-recommended-rules into b51dd95 on evcohen:master.

@beefancohen beefancohen merged commit 66509a3 into jsx-eslint:master Apr 26, 2016
@beefancohen
Copy link
Contributor

Ah, careless errors. Thanks! Getting a 500 on trying to publish v1.0.3 - will comment as soon as its resolved.

@YellowKirby YellowKirby deleted the fix-typo-recommended-rules branch April 26, 2016 00:56
@beefancohen
Copy link
Contributor

beefancohen commented Apr 26, 2016 •
edited

v1.0.3 was published. thanks for the PR 😄

@YellowKirby
Copy link
Contributor Author

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YellowKirby @coveralls @beefancohen