[Refactor] removing a use of some
#682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
jessebeach
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
@andrelmlins ya, I think it works. How in the world did you find this??
|
Hi @jessebeach , I was implementing accessibility rules for SvelteJs. When comparing my code with this one, I noticed this point. |
ljharb
requested changes
Jun 11, 2020
ljharb
changed the title
some
Co-authored-by: Jordan Harband <ljharb@gmail.com>
jessebeach
approved these changes
Jun 11, 2020
|
@ljharb, @andrelmlins made the change. Could you approve and I'll merge it? |
ljharb
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that it is not necessary to use the add function. Leaving the whole rule to the Regex.