Add WCAG guidelines to rule documentation #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessebeach @WilcoFiers would love your eyes on this to validate the content I added, especially around whether the WCAG criteria I added are the appropriate criteria |
backwardok
force-pushed
the
add-wcag
branch
2 times, most recently
from
1a13a3d
to
c1436ae
Compare
Adds in a section for every rule that specifies what the WCAG guidelines are (if applicable) in a new Accessibility guidelines section near the bottom of the rule documentation. Additional changes: - Move Resources/References underneath Accessibility guidelines section - Fix up heading level of Resources so that the heading order progresses sequentially - Fix up resource link text to be clearer - Fix up some broken links or old references - Update pronoun usage in `accessible-emoji` to use they instead of he/she - Add some additional examples and rule clarity to `click-events-have-key-events` - Fix up code formatting for `tabindex-no-positive` - Add additional resources to some rules without resources - Change Resources from ordered list to unordered list since the order really doesn't matter Partially addresses jsx-eslint#30
ljharb
approved these changes
Jun 27, 2020
|
Hi @backwardok !!! Thank you for these improvements!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in a section for every rule that specifies what the WCAG guidelines are (if applicable) in a new Accessibility guidelines section near the bottom of the rule documentation.
Additional changes:
accessible-emojito use they instead of he/sheclick-events-have-key-eventstabindex-no-positivePartially addresses #30