[Dev Deps] move semver from Deps to Dev Deps
#944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be merged as part of #941. |
ljharb
force-pushed
the
move-semver-to-devdeps
branch
from
7def298
to
4da13e7
Compare
|
I ended up removing the change from #941, so now I've rebased this, and will land it shortly. |
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 99.29% 99.29%
=======================================
Files 104 104
Lines 1554 1554
Branches 522 522
=======================================
Hits 1543 1543
Misses 11 11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #943
I noticed that
semveris actually only used in the unit test cases, so it is safe to movesemverto thedevDependencies.