Fix require-optimization warning on stateless components (fixes #687)

jsx-eslint · Jul 25, 2016 · 046a723 · 046a723
1 parent c7a6c67
commit 046a723
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/rules/require-optimization.js b/lib/rules/require-optimization.js
@@ -134,6 +134,11 @@ module.exports = Components.detect(function (context, components) {
       markSCUAsDeclared(node);
     },
 
+    FunctionDeclaration: function (node) {
+      // Stateless Functional Components cannot be optimized (yet)
+      markSCUAsDeclared(node);
+    },
+
     FunctionExpression: function (node) {
       // Stateless Functional Components cannot be optimized (yet)
       markSCUAsDeclared(node);

diff --git a/tests/lib/rules/require-optimization.js b/tests/lib/rules/require-optimization.js
@@ -69,6 +69,14 @@ ruleTester.run('react-require-optimization', rule, {
     ].join('\n'),
     parser: 'babel-eslint',
     parserOptions: parserOptions
+  }, {
+    code: [
+      'function FunctionalComponent(props) {' +
+      'return <div />;' +
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    parserOptions: parserOptions
   }, {
     code: [
       'const FunctionalComponent = (props) => {' +