Fix sort-comp crash on spread operator (fixes #624)

jsx-eslint · Jun 6, 2016 · 0aeebaf · 0aeebaf
1 parent aa359fb
commit 0aeebaf
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -247,7 +247,9 @@ module.exports = Components.detect(function(context, components) {
       case 'ClassDeclaration':
         return node.body.body;
       case 'ObjectExpression':
-        return node.properties;
+        return node.properties.filter(function(property) {
+          return property.type === 'Property';
+        });
       default:
         return [];
     }

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -192,6 +192,17 @@ ruleTester.run('sort-comp', rule, {
       ')'
     ].join('\n'),
     parser: 'babel-eslint'
+  }, {
+    // Must ignore spread operator
+    code: [
+      'var Hello = React.createClass({',
+      '  ...proto,',
+      '  render: function() {',
+      '    return <div>Hello</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{