Add support for prefixes in flow prop-types

jsx-eslint · Aug 22, 2017 · 217d33e · 217d33e
1 parent 44ca52b
commit 217d33e
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 19 deletions.
diff --git a/lib/rules/no-unused-prop-types.js b/lib/rules/no-unused-prop-types.js
@@ -265,7 +265,7 @@ module.exports = {
      */
     function getKeyValue(node) {
       if (node.type === 'ObjectTypeProperty') {
-        const tokens = context.getFirstTokens(node, 1);
+        const tokens = context.getFirstTokens(node, {count: 1, filter: tokenNode => tokenNode.type === 'Identifier'});
         return tokens[0].value;
       }
       const key = node.key || node.argument;

diff --git a/tests/lib/rules/no-unused-prop-types.js b/tests/lib/rules/no-unused-prop-types.js
@@ -2032,27 +2032,40 @@ ruleTester.run('no-unused-prop-types', rule, {
     }, {
       // issue #106
       code: `
-      import React from 'react';
-      import SharedPropTypes from './SharedPropTypes';
+        import React from 'react';
+        import SharedPropTypes from './SharedPropTypes';
 
-      export default class A extends React.Component {
-        render() {
-          return (
-            <span
-              a={this.props.a}
-              b={this.props.b}
-              c={this.props.c}>
-              {this.props.children}
-            </span>
-          );
+        export default class A extends React.Component {
+          render() {
+            return (
+              <span
+                a={this.props.a}
+                b={this.props.b}
+                c={this.props.c}>
+                {this.props.children}
+              </span>
+            );
+          }
         }
-      }
 
-      A.propTypes = {
-        a: React.PropTypes.string,
-        ...SharedPropTypes // eslint-disable-line object-shorthand
-      };
-    `,
+        A.propTypes = {
+          a: React.PropTypes.string,
+          ...SharedPropTypes // eslint-disable-line object-shorthand
+        };
+      `,
+      parser: 'babel-eslint'
+    }, {
+      // issue #933
+      code: `
+        type Props = {
+          +foo: number
+        }
+        class MyComponent extends React.Component {
+          render() {
+            return <div>{this.props.foo}</div>
+          }
+        }
+      `,
       parser: 'babel-eslint'
     }
   ],