Fix jsx-handler-names crash with arrays (fixes #340)

jsx-eslint · Nov 30, 2015 · 2204feb · 2204feb
1 parent db6f841
commit 2204feb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -26,8 +26,8 @@ module.exports = function(context) {
   function rebuildPropValue(valueNode) {
     var valueNodeObject = valueNode.object;
     var subObjectType = valueNodeObject.object ? valueNodeObject.object.type : '';
-    var propertyName = valueNodeObject.property ? valueNodeObject.property.name : '';
-    var propValue = valueNode.property ? valueNode.property.name : '';
+    var propertyName = valueNodeObject.property && valueNodeObject.property.name ? valueNodeObject.property.name : '';
+    var propValue = valueNode.property && valueNode.property.name ? valueNode.property.name : '';
 
     if (propertyName.length) {
       propValue = propertyName + '.' + propValue;

diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js
@@ -52,6 +52,13 @@ ruleTester.run('jsx-handler-names', rule, {
     ecmaFeatures: {
       jsx: true
     }
+  }, {
+    code: [
+      '<TestComponent shouldDisplay={arr[0].prop} />'
+    ].join('\n'),
+    ecmaFeatures: {
+      jsx: true
+    }
   }],
 
   invalid: [{