Fix classes with properties to always be marked as components (fixes #…

…291)
jsx-eslint · Nov 7, 2015 · 2929aaa · 2929aaa
1 parent a09ac73
commit 2929aaa
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -206,7 +206,7 @@ function componentRule(rule, context) {
         scope = scope.upper;
       }
       var node = scope && scope.block;
-      if (!node || !node.superClass) {
+      if (!node || !context.react.isES6Component(node)) {
         return null;
       }
       return node;

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -57,6 +57,16 @@ ruleTester.run('display-name', rule, {
       classes: true,
       jsx: true
     }
+  }, {
+    code: [
+      'class Hello extends Greetings {',
+      '  static text = \'Hello World\';',
+      '  render() {',
+      '    return Hello.text;',
+      '  }',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }, {
     code: [
       'class Hello {',