Fix require-extension to ignore extension if it's part of the package…

… name (fixes #319)
jsx-eslint · Nov 29, 2015 · 312d66a · 312d66a
1 parent 2153154
commit 312d66a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/rules/require-extension.js b/lib/rules/require-extension.js
@@ -14,12 +14,18 @@ var DEFAULTS = {
   extentions: ['.jsx']
 };
 
+var PKG_REGEX = /^[^\.]((?!\/).)*$/;
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
 
 module.exports = function(context) {
 
+  function isPackage(id) {
+    return PKG_REGEX.test(id);
+  }
+
   function isRequire(expression) {
     return expression.callee.name === 'require';
   }
@@ -53,8 +59,9 @@ module.exports = function(context) {
 
     CallExpression: function(node) {
       if (isRequire(node)) {
-        var ext = getExtension(getId(node));
-        if (isForbiddenExtension(ext)) {
+        var id = getId(node);
+        var ext = getExtension(id);
+        if (!isPackage(id) && isForbiddenExtension(ext)) {
           context.report(node, 'Unable to require module with extension \'' + ext + '\'');
         }
       }

diff --git a/tests/lib/rules/require-extension.js b/tests/lib/rules/require-extension.js
@@ -17,6 +17,8 @@ var RuleTester = require('eslint').RuleTester;
 
 var REQUIRE_PACKAGE = 'require(\'eslint\')';
 
+var REQUIRE_PACKAGE_JS = 'require(\'headroom.js\')';
+
 var REQUIRE_JS = 'require(\'./index.js\')';
 
 var REQUIRE_JSX = 'require(\'./index.jsx\')';
@@ -66,6 +68,9 @@ ruleTester.run('require-extension', rule, {
     }, {
       code: REQUIRE_JSX,
       options: [{extensions: ['.js']}]
+    }, {
+      code: REQUIRE_PACKAGE_JS,
+      options: [{extensions: ['.js']}]
     }
   ],