Fix this usage in jsx-no-undef (fixes #489)

jsx-eslint · Mar 14, 2016 · 37fc544 · 37fc544
1 parent 259fab4
commit 37fc544
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/rules/jsx-no-undef.js b/lib/rules/jsx-no-undef.js
@@ -32,6 +32,11 @@ module.exports = function(context) {
     var i;
     var len;
 
+    // Ignore 'this' keyword (also maked as JSXIdentifier when used in JSX)
+    if (node.name === 'this') {
+      return;
+    }
+
     while (scope.type !== 'global') {
       scope = scope.upper;
       variables = scope.variables.concat(variables);

diff --git a/tests/lib/rules/jsx-no-undef.js b/tests/lib/rules/jsx-no-undef.js
@@ -45,6 +45,17 @@ ruleTester.run('jsx-no-undef', rule, {
   }, {
     code: '/*eslint no-undef:1*/ var React, app; React.render(<app.foo.Bar />);',
     parserOptions: parserOptions
+  }, {
+    code: [
+      '/*eslint no-undef:1*/',
+      'var React;',
+      'class Hello extends React.Component {',
+      '  render() {',
+      '    return <this.props.tag />',
+      '  }',
+      '}'
+    ].join('\n'),
+    parserOptions: parserOptions
   }],
   invalid: [{
     code: '/*eslint no-undef:1*/ var React; React.render(<App />);',