[Fix] button-has-type: fix exception for <button type>

jsx-eslint · Mar 23, 2022 · 458ebfc · 458ebfc
1 parent 2145e29
commit 458ebfc
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rules/button-has-type.js b/lib/rules/button-has-type.js
@@ -126,7 +126,7 @@ module.exports = {
           return;
         }
 
-        if (typeProp.value.type === 'JSXExpressionContainer') {
+        if (typeProp.value && typeProp.value.type === 'JSXExpressionContainer') {
           checkExpression(node, typeProp.value.expression);
           return;
         }

diff --git a/tests/lib/rules/button-has-type.js b/tests/lib/rules/button-has-type.js
@@ -179,6 +179,15 @@ ruleTester.run('button-has-type', rule, {
         },
       ],
     },
+    {
+      code: '<button type/>',
+      errors: [
+        {
+          messageId: 'invalidValue',
+          data: { value: true },
+        },
+      ],
+    },
     {
       code: '<button type={condition ? "reset" : "button"}/>',
       options: [{ reset: false }],