address comments - remove auto-fixer and adapt tests

jsx-eslint · Jan 16, 2022 · 4de38ef · 4de38ef
1 parent 17f2878
commit 4de38ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/lib/rules/no-invalid-html-attribute.js b/lib/rules/no-invalid-html-attribute.js
@@ -321,11 +321,6 @@ function checkLiteralValueNode(context, attributeName, node, parentNode, parentN
                 secondValue,
                 missingValue: [...siblings].join(', '),
               },
-              fix(fixer) {
-                if (siblings.size === 1) {
-                  return fixer.replaceTextRange(singleAttributeParts[0].range, `${pairing}\u0020${[...siblings][0]}`);
-                }
-              },
             });
           }
         }

diff --git a/tests/lib/rules/no-invalid-html-attribute.js b/tests/lib/rules/no-invalid-html-attribute.js
@@ -387,7 +387,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
       ],
     },
     {
-      code: '<a rel="noreferrer  noopener"></a>', // this string contains nbsp
+      code: '<a rel="noreferrer\xa0\xa0noopener"></a>',
       output: '<a rel="noreferrer noopener"></a>',
       errors: [
         {
@@ -562,7 +562,6 @@ ruleTester.run('no-invalid-html-attribute', rule, {
     },
     {
       code: '<link rel="shortcut"></link>',
-      output: '<link rel="shortcut icon"></link>',
       errors: [
         {
           messageId: 'notAlone',
@@ -575,7 +574,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
     },
     {
       code: '<link rel="shortcut foo"></link>',
-      output: '<link rel="shortcut icon "></link>',
+      output: '<link rel="shortcut "></link>',
       errors: [
         {
           messageId: 'neverValid',
@@ -606,7 +605,7 @@ ruleTester.run('no-invalid-html-attribute', rule, {
     },
     {
       code: '<link rel="shortcut  foo"></link>',
-      output: '<link rel="shortcut icon  "></link>',
+      output: '<link rel="shortcut foo"></link>',
       errors: [
         {
           messageId: 'neverValid',