Add support for wrapped propTypes to require-default-props

jsx-eslint · Jun 24, 2017 · 4df159b · 4df159b
1 parent 61b65a0
commit 4df159b
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 1 deletion.
diff --git a/lib/rules/require-default-props.js b/lib/rules/require-default-props.js
@@ -22,11 +22,25 @@ module.exports = {
       category: 'Best Practices'
     },
 
-    schema: []
+    schema: [{
+      type: 'object',
+      properties: {
+        propWrapperFunctions: {
+          type: 'array',
+          items: {
+            type: 'string'
+          },
+          uniqueItems: true
+        }
+      },
+      additionalProperties: false
+    }]
   },
 
   create: Components.detect(function(context, components, utils) {
     var sourceCode = context.getSourceCode();
+    var configuration = context.options[0] || {};
+    var propWrapperFunctions = new Set(configuration.propWrapperFunctions || []);
 
     /**
      * Get properties name
@@ -105,6 +119,13 @@ module.exports = {
       if (node.type === 'Identifier') {
         return findVariableByName(node.name);
       }
+      if (
+        node.type === 'CallExpression' &&
+        propWrapperFunctions.has(node.callee.name) &&
+        node.arguments && node.arguments[0]
+      ) {
+        return node.arguments[0];
+      }
 
       return node;
     }

diff --git a/tests/lib/rules/require-default-props.js b/tests/lib/rules/require-default-props.js
@@ -757,6 +757,23 @@ ruleTester.run('require-default-props', rule, {
         column: 3
       }]
     },
+    {
+      code: [
+        'function MyStatelessComponent({ foo, bar }) {',
+        '  return <div>{foo}{bar}</div>;',
+        '}',
+        'MyStatelessComponent.propTypes = forbidExtraProps({',
+        '  foo: PropTypes.string,',
+        '  bar: PropTypes.string.isRequired',
+        '});'
+      ].join('\n'),
+      errors: [{
+        message: 'propType "foo" is not required, but has no corresponding defaultProp declaration.',
+        line: 5,
+        column: 3
+      }],
+      options: [{propWrapperFunctions: ['forbidExtraProps']}]
+    },
     {
       code: [
         'function MyStatelessComponent({ foo, bar }) {',