[Fix] no-unknown-property: onError and onLoad both work on `img…

…` and `script` Fixes #3388
jsx-eslint · Sep 4, 2022 · 51ec858 · 51ec858
1 parent 8116891
commit 51ec858
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-unknown-property`]: `onError` and `onLoad` both work on `img` and `script` ([#3388][] @ljharb)
+
+[#3388]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3388
+
 ## [7.31.5] - 2022.09.03
 
 ### Fixed
@@ -14,7 +19,7 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [`no-unknown-property`]: `children` is always an acceptable prop; iframes have `scrolling`; video has `playsInline` ([#3385][] @ljharb)
 
 [7.31.5]: https://github.com/jsx-eslint/eslint-plugin-react/compare/v7.31.4...v7.31.5
-[#3385]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3385
+[#3385]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3385
 
 ## [7.31.4] - 2022.09.03
 

diff --git a/lib/rules/no-unknown-property.js b/lib/rules/no-unknown-property.js
@@ -63,7 +63,8 @@ const ATTRIBUTE_TAGS_MAP = {
   onEmptied: ['audio', 'video'],
   onEncrypted: ['audio', 'video'],
   onEnded: ['audio', 'video'],
-  onError: ['audio', 'video'],
+  onError: ['audio', 'video', 'img', 'script'],
+  onLoad: ['script', 'img'],
   onLoadedData: ['audio', 'video'],
   onLoadedMetadata: ['audio', 'video'],
   onLoadStart: ['audio', 'video'],

diff --git a/tests/lib/rules/no-unknown-property.js b/tests/lib/rules/no-unknown-property.js
@@ -57,6 +57,8 @@ ruleTester.run('no-unknown-property', rule, {
     { code: '<meta property="og:type" content="website" />' },
     { code: '<input type="checkbox" checked={checked} disabled={disabled} id={id} onChange={onChange} />' },
     { code: '<video playsInline />' },
+    { code: '<img onError={foo} onLoad={bar} />' },
+    { code: '<script onLoad={bar} onError={foo} />' },
     {
       code: '<div allowTransparency="true" />',
       settings: {
@@ -383,7 +385,7 @@ ruleTester.run('no-unknown-property', rule, {
           data: {
             name: 'onError',
             tagName: 'div',
-            allowedTags: 'audio, video',
+            allowedTags: 'audio, video, img, script',
           },
         },
       ],