Merge pull request #1621 from kamataryo/master

Add null avoidance in rule `require-optimization`
jsx-eslint · Dec 22, 2017 · 5f1ec80 · 5f1ec80
2 parents f40b7b8 + 22c9237
commit 5f1ec80
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/rules/require-optimization.js b/lib/rules/require-optimization.js
@@ -106,7 +106,7 @@ module.exports = {
       let hasPR = false;
       if (node.value && node.value.elements) {
         for (let i = 0, l = node.value.elements.length; i < l; i++) {
-          if (node.value.elements[i].name === 'PureRenderMixin') {
+          if (node.value.elements[i] && node.value.elements[i].name === 'PureRenderMixin') {
             hasPR = true;
             break;
           }

diff --git a/tests/lib/rules/require-optimization.js b/tests/lib/rules/require-optimization.js
@@ -112,6 +112,10 @@ ruleTester.run('react-require-optimization', rule, {
     `,
     parser: 'babel-eslint',
     options: [{allowDecorators: ['renderPure', 'pureRender']}]
+  }, {
+    code: `
+      const obj = { prop: [,,,,,] }
+    `
   }],
 
   invalid: [{