Fix display-name false negative on es6-style method in React.createCl…

…ass (fixes #852)
jsx-eslint · Sep 21, 2016 · 644b2ee · 644b2ee
1 parent 8ae52a9
commit 644b2ee
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/rules/display-name.js b/lib/rules/display-name.js
@@ -125,7 +125,8 @@ module.exports = {
       var namedFunctionExpression = (
         (node.type === 'FunctionExpression' || node.type === 'ArrowFunctionExpression') &&
         node.parent &&
-        (node.parent.type === 'VariableDeclarator' || node.parent.method === true)
+        (node.parent.type === 'VariableDeclarator' || node.parent.method === true) &&
+        (!node.parent.parent || !utils.isES5Component(node.parent.parent))
       );
 
       if (

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -464,6 +464,18 @@ ruleTester.run('display-name', rule, {
     errors: [{
       message: 'Component definition is missing display name'
     }]
+  }, {
+    code: [
+      'module.exports = React.createClass({',
+      '  render() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{
+      message: 'Component definition is missing display name'
+    }]
   }, {
     code: [
       'var Hello = React.createClass({',