handle ternary operation for jsx-no-bind

jsx-eslint · Mar 13, 2018 · 7a9ac14 · 7a9ac14
1 parent 06ed294
commit 7a9ac14
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/lib/rules/jsx-no-bind.js b/lib/rules/jsx-no-bind.js
@@ -81,6 +81,10 @@ module.exports = {
         node.callee.property.name === 'bind'
       ) {
         return 'bindCall';
+      } else if (
+        nodeType === 'ConditionalExpression'
+      ) {
+        return getNodeViolationType(node.consequent) | getNodeViolationType(node.alternate);
       } else if (
         !configuration.allowArrowFunctions &&
         nodeType === 'ArrowFunctionExpression'
@@ -154,7 +158,7 @@ module.exports = {
         }
       },
 
-      JSXAttribute: function(node) {
+      JSXAttribute: function (node) {
         const isRef = configuration.ignoreRefs && propName(node) === 'ref';
         if (isRef || !node.value || !node.value.expression) {
           return;

diff --git a/tests/lib/rules/jsx-no-bind.js b/tests/lib/rules/jsx-no-bind.js
@@ -397,6 +397,36 @@ ruleTester.run('jsx-no-bind', rule, {
       ],
       parser: 'babel-eslint'
     },
+    {
+      code: `
+        const foo = {
+          render: ({onClick}) => (
+            <div onClick={(true) ? onClick.bind(this) : onClick.bind(this)}>Hello</div>
+          )
+        };
+      `,
+      errors: [{message: 'JSX props should not use .bind()'}]
+    },
+    {
+      code: `
+        const foo = {
+          render: ({onClick}) => (
+            <div onClick={(true) ? onClick.bind(this) : handleClick()}>Hello</div>
+          )
+        };
+      `,
+      errors: [{message: 'JSX props should not use .bind()'}]
+    },
+    {
+      code: `
+        const foo = {
+          render: ({onClick}) => (
+            <div onClick={(true) ? handleClick() : onClick.bind(this)}>Hello</div>
+          )
+        };
+      `,
+      errors: [{message: 'JSX props should not use .bind()'}]
+    },
 
     // Arrow functions
     {