Fix crash in prop-types when encountering an empty variable declarati…

…on (fixes #130)
jsx-eslint · Jun 28, 2015 · 8682320 · 8682320
1 parent 3e280a6
commit 8682320
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -533,7 +533,7 @@ module.exports = function(context) {
     },
 
     VariableDeclarator: function(node) {
-      if (node.init.type !== 'ThisExpression' || node.id.type !== 'ObjectPattern') {
+      if (!node.init || node.init.type !== 'ThisExpression' || node.id.type !== 'ObjectPattern') {
         return;
       }
       markPropTypesAsUsed(node);

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -894,8 +894,10 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
       code: [
         'class Hello extends React.Component {',
         '  render() {',
+        '    var text;',
+        '    text = \'Hello \';',
         '    let {props: {firstname}} = this;',
-        '    return <div>Hello {firstname}</div>;',
+        '    return <div>{text} {firstname}</div>;',
         '  }',
         '}'
       ].join('\n'),