Add fix for multple props on first line

fix referenced from GovTechSG's fork
jsx-eslint · Nov 2, 2016 · a37687e · a37687e
1 parent 0aeb95c
commit a37687e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lib/rules/jsx-first-prop-new-line.js b/lib/rules/jsx-first-prop-new-line.js
@@ -36,7 +36,7 @@ module.exports = {
           (configuration === 'multiline-multiprop' && isMultilineJSX(node) && node.attributes.length > 1) ||
           (configuration === 'always')
         ) {
-          node.attributes.forEach(function(decl) {
+          node.attributes.some(function(decl) {
             if (decl.loc.start.line === node.loc.start.line) {
               context.report({
                 node: decl,
@@ -46,6 +46,7 @@ module.exports = {
                 }
               });
             }
+            return true;
           });
         } else if (configuration === 'never' && node.attributes.length > 0) {
           var firstNode = node.attributes[0];

diff --git a/tests/lib/rules/jsx-first-prop-new-line.js b/tests/lib/rules/jsx-first-prop-new-line.js
@@ -152,10 +152,10 @@ ruleTester.run('jsx-first-prop-new-line', rule, {
 
   invalid: [
     {
-      code: '<Foo prop="one" />',
+      code: '<Foo propOne="one" propTwo="two" />',
       output: [
         '<Foo',
-        'prop="one" />'
+        'propOne="one" propTwo="two" />'
       ].join('\n'),
       options: ['always'],
       errors: [{message: 'Property should be placed on a new line'}],