chore: use minmatch to match pattern

jsx-eslint · May 7, 2024 · a8e1185 · a8e1185
1 parent d733852
commit a8e1185
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 2 deletions.
diff --git a/lib/rules/no-danger.js b/lib/rules/no-danger.js
@@ -7,6 +7,7 @@
 
 const has = require('object.hasown/polyfill')();
 const fromEntries = require('object.fromentries/polyfill')();
+const minimatch = require('minimatch');
 
 const docsUrl = require('../util/docsUrl');
 const jsxUtil = require('../util/jsx');
@@ -79,7 +80,7 @@ module.exports = {
         const functionName = node.parent.name.name;
 
         const enableCheckingCustomComponent = customComponentNames.length > 0
-          && (customComponentNames[0] === '*' || customComponentNames.some((name) => functionName === name));
+          && customComponentNames.some((name) => minimatch(functionName, name));
 
         if ((enableCheckingCustomComponent || jsxUtil.isDOMComponent(node.parent)) && isDangerous(node.name.name)) {
           report(context, messages.dangerousProp, 'dangerousProp', {

diff --git a/tests/lib/rules/no-danger.js b/tests/lib/rules/no-danger.js
@@ -32,7 +32,10 @@ ruleTester.run('no-danger', rule, {
     { code: '<App />;' },
     { code: '<App dangerouslySetInnerHTML={{ __html: "" }} />;' },
     { code: '<div className="bar"></div>;' },
-    { code: '<div className="bar"></div>;', options: [{ customComponentNames: ['*'] }] },
+    {
+      code: '<div className="bar"></div>;',
+      options: [{ customComponentNames: ['*'] }],
+    },
     {
       code: `
         function App() {
@@ -41,6 +44,14 @@ ruleTester.run('no-danger', rule, {
       `,
       options: [{ customComponentNames: ['Home'] }],
     },
+    {
+      code: `
+        function App() {
+          return <TextMUI dangerouslySetInnerHTML={{ __html: "<span>hello</span>" }} />;
+        }
+      `,
+      options: [{ customComponentNames: ['MUI*'] }],
+    },
   ]),
   invalid: parsers.all([
     {
@@ -76,5 +87,33 @@ ruleTester.run('no-danger', rule, {
       ],
       options: [{ customComponentNames: ['Title'] }],
     },
+    {
+      code: `
+        function App() {
+          return <TextFoo dangerouslySetInnerHTML={{ __html: "<span>hello</span>" }} />;
+        }
+      `,
+      errors: [
+        {
+          messageId: 'dangerousProp',
+          data: { name: 'dangerouslySetInnerHTML' },
+        },
+      ],
+      options: [{ customComponentNames: ['*Foo'] }],
+    },
+    {
+      code: `
+        function App() {
+          return <FooText dangerouslySetInnerHTML={{ __html: "<span>hello</span>" }} />;
+        }
+      `,
+      errors: [
+        {
+          messageId: 'dangerousProp',
+          data: { name: 'dangerouslySetInnerHTML' },
+        },
+      ],
+      options: [{ customComponentNames: ['Foo*'] }],
+    },
   ]),
 });