Fix require-default-props error message for quoted props (fixes #1161)

jsx-eslint · May 11, 2017 · af68f88 · af68f88
1 parent f7fb96b
commit af68f88
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/require-default-props.js b/lib/rules/require-default-props.js
@@ -142,7 +142,7 @@ module.exports = {
 
       return props.map(function(property) {
         return {
-          name: property.key.name,
+          name: property.key.name || property.key.value,
           isRequired: isRequiredPropType(property.value),
           node: property
         };

diff --git a/tests/lib/rules/require-default-props.js b/tests/lib/rules/require-default-props.js
@@ -1805,6 +1805,24 @@ ruleTester.run('require-default-props', rule, {
       errors: [{
         message: 'propType "name" is not required, but has no corresponding defaultProp declaration.'
       }]
+    },
+    {
+      code: [
+        'class Hello extends React.Component {',
+        '  static get propTypes() {',
+        '    return {',
+        '      \'first-name\': PropTypes.string',
+        '    };',
+        '  }',
+        '  render() {',
+        '    return <div>Hello {this.props[\'first-name\']}</div>;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'propType "first-name" is not required, but has no corresponding defaultProp declaration.'
+      }]
     }
   ]
 });