Fix invalid class property handling in jsx-sort-prop-types (fixes #129)

jsx-eslint · Jun 26, 2015 · b1e1f40 · b1e1f40
1 parent 338e530
commit b1e1f40
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/jsx-sort-prop-types.js b/lib/rules/jsx-sort-prop-types.js
@@ -65,7 +65,7 @@ module.exports = function(context) {
 
   return {
     ClassProperty: function(node) {
-      if (isPropTypesDeclaration(node) && node.value.type === 'ObjectExpression') {
+      if (isPropTypesDeclaration(node) && node.value && node.value.type === 'ObjectExpression') {
         checkSorted(node.value.properties);
       }
     },

diff --git a/tests/lib/rules/jsx-sort-prop-types.js b/tests/lib/rules/jsx-sort-prop-types.js
@@ -176,6 +176,21 @@ eslintTester.addRuleTest('lib/rules/jsx-sort-prop-types', {
       args: [1, {
         ignoreCase: true
       }]
+    }, {
+      // Invalid code, should not be validated
+      code: [
+        'class Component extends React.Component {',
+        '  propTypes: {',
+        '    a: React.PropTypes.any,',
+        '    c: React.PropTypes.any,',
+        '    b: React.PropTypes.any',
+        '  }',
+        '  render() {',
+        '    return <div />;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],