[Fix] no-unknown-property: add dialog attributes

Fixes #3436
jsx-eslint · Sep 17, 2022 · b52e0ca · b52e0ca
1 parent 8c9ec8a
commit b52e0ca
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`no-unknown-property`]: add `dialog` attributes ([#3436][] @ljharb)
+
+[#3436]: https://github.com/jsx-eslint/eslint-plugin-react/issues/3436
+
 ## [7.31.8] - 2022.09.08
 
 ### Fixed

diff --git a/lib/rules/no-unknown-property.js b/lib/rules/no-unknown-property.js
@@ -70,8 +70,10 @@ const ATTRIBUTE_TAGS_MAP = {
   noModule: ['script'],
   // Media events allowed only on audio and video tags, see https://github.com/facebook/react/blob/256aefbea1449869620fb26f6ec695536ab453f5/CHANGELOG.md#notable-enhancements
   onAbort: ['audio', 'video'],
+  onCancel: ['dialog'],
   onCanPlay: ['audio', 'video'],
   onCanPlayThrough: ['audio', 'video'],
+  onClose: ['dialog'],
   onDurationChange: ['audio', 'video'],
   onEmptied: ['audio', 'video'],
   onEncrypted: ['audio', 'video'],
@@ -104,6 +106,7 @@ const ATTRIBUTE_TAGS_MAP = {
   poster: ['video'],
   preload: ['audio', 'video'],
   scrolling: ['iframe'],
+  returnValue: ['dialog'],
 };
 
 const SVGDOM_ATTRIBUTE_NAMES = {

diff --git a/tests/lib/rules/no-unknown-property.js b/tests/lib/rules/no-unknown-property.js
@@ -128,6 +128,7 @@ ruleTester.run('no-unknown-property', rule, {
     { code: '<view id="one" viewBox="0 0 100 100" />' },
     { code: '<hr align="top" />' },
     { code: '<applet align="top" />' },
+    { code: '<dialog onClose={handler} open id="dialog" returnValue="something" onCancel={handler2} />' },
     {
       code: `
         <table align="top">