Fix no-danger-with-children crash with undefined (fixes #1287)

jsx-eslint · Jul 5, 2017 · bef5897 · jseminck · Jul 5, 2017 · yannickcr
1 parent 65b746e
commit bef5897
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/rules/no-danger-with-children.js b/lib/rules/no-danger-with-children.js
@@ -110,7 +110,7 @@ module.exports = {
             const variable = variableUtil.variablesInScope(context).find(function (item) {
               return item.name === props.name;
             });
-            if (variable && variable.defs[0].node.init) {
+            if (variable && variable.defs.length && variable.defs[0].node.init) {
               props = variable.defs[0].node.init;
             }
           }

diff --git a/tests/lib/rules/no-danger-with-children.js b/tests/lib/rules/no-danger-with-children.js
@@ -85,6 +85,12 @@ ruleTester.run('no-danger-with-children', rule, {
     },
     {
       code: 'React.createElement("Hello", {}, "Children");'
+    },
+    {
+      code: '<Hello {...undefined}>Children</Hello>'
+    },
+    {
+      code: 'React.createElement("Hello", undefined, "Children")'
     }
   ],
   invalid: [