Merge pull request #409 from alitaheri/fix-408

Fix jsx-sort-prop-types issue with custom propTypes (fixes #408)
jsx-eslint · Jan 24, 2016 · c1ce38b · c1ce38b
2 parents d7c3ad2 + eede741
commit c1ce38b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/lib/rules/jsx-sort-prop-types.js b/lib/rules/jsx-sort-prop-types.js
@@ -40,7 +40,7 @@ module.exports = function(context) {
   }
 
   function getValueName(node) {
-    return node.value.property.name;
+    return node.value.property && node.value.property.name;
   }
 
   function isCallbackPropName(propName) {

diff --git a/tests/lib/rules/jsx-sort-prop-types.js b/tests/lib/rules/jsx-sort-prop-types.js
@@ -276,6 +276,21 @@ ruleTester.run('jsx-sort-prop-types', rule, {
       requiredFirst: true
     }],
     parserOptions: parserOptions
+  }, {
+    code: [
+      'class First extends React.Component {',
+      '  render() {',
+      '    return <div />;',
+      '  }',
+      '}',
+      'First.propTypes = {',
+      '    fooRequired: MyPropType,',
+      '};'
+    ].join('\n'),
+    options: [{
+      requiredFirst: true
+    }],
+    parserOptions: parserOptions
   }, {
     code: [
       'class First extends React.Component {',