Check for createElement being called from React

Fixes #996. This will prevent document.createElement triggering a false positive for react/display-name.
jsx-eslint · Jan 2, 2017 · c6264d0 · c6264d0
1 parent 682ae68
commit c6264d0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -258,6 +258,8 @@ function componentRule(rule, context) {
       var returnsReactCreateElement =
         node[property] &&
         node[property].callee &&
+        node[property].callee.object &&
+        node[property].callee.object.name === 'React' &&
         node[property].callee.property &&
         node[property].callee.property.name === 'createElement'
       ;

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -378,6 +378,13 @@ ruleTester.run('display-name', rule, {
       ')'
     ].join('\n'),
     parser: 'babel-eslint'
+  }, {
+    code: [
+      'module.exports = {',
+      '  createElement: tagName => document.createElement(tagName)',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint'
   }],
 
   invalid: [{