Fix jsx-quotes rule deprecation message (fixes #220)

jsx-eslint · Sep 16, 2015 · cf3d0cc · cf3d0cc
1 parent edd89f6
commit cf3d0cc
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 27 deletions.
diff --git a/lib/rules/jsx-quotes.js b/lib/rules/jsx-quotes.js
@@ -23,6 +23,8 @@ var QUOTE_SETTINGS = {
 
 var AVOID_ESCAPE = 'avoid-escape';
 
+var isWarnedForDeprecation = false;
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -42,8 +44,14 @@ module.exports = function(context) {
 
   return {
 
-    Program: function(node) {
-      context.report(node, 'The react/jsx-quotes rule is deprecated. Please use the jsx-quotes rule instead.');
+    Program: function() {
+      if (isWarnedForDeprecation) {
+        return;
+      }
+      /* eslint-disable no-console */
+      console.log('The react/jsx-quotes rule is deprecated. Please use the jsx-quotes rule instead.');
+      /* eslint-enable no-console */
+      isWarnedForDeprecation = true;
     },
 
     Literal: function(node) {

diff --git a/tests/lib/rules/jsx-quotes.js b/tests/lib/rules/jsx-quotes.js
@@ -12,41 +12,23 @@
 var rule = require('../../../lib/rules/jsx-quotes');
 var RuleTester = require('eslint').RuleTester;
 
-var DEPRECATION_WARNING = 'The react/jsx-quotes rule is deprecated. Please use the jsx-quotes rule instead.';
-var SINGLEQUOTE_WARNING = 'JSX attributes must use singlequote.';
-var DOUBLEQUOTE_WARNING = 'JSX attributes must use doublequote.';
-
 // -----------------------------------------------------------------------------
 // Tests
 // -----------------------------------------------------------------------------
 
 var ruleTester = new RuleTester();
 ruleTester.run('jsx-quotes', rule, {
   valid: [
-    // None, should always trigger at least the deprecation warning
+    {code: '<App foo=\'bar\' />;', options: ['single'], ecmaFeatures: {jsx: true}},
+    {code: '<App foo="bar" />;', options: ['double'], ecmaFeatures: {jsx: true}},
+    {code: '<App foo="ba\'r" />;', options: ['single', 'avoid-escape'], ecmaFeatures: {jsx: true}},
+    {code: '<App foo=\'ba"r\' />;', options: ['double', 'avoid-escape'], ecmaFeatures: {jsx: true}},
+    {code: '<App>foo</App>;', options: ['single'], ecmaFeatures: {jsx: true}}
   ],
   invalid: [
-    {code: '<App />;',
-     errors: [{message: DEPRECATION_WARNING}], ecmaFeatures: {jsx: true}},
-    {code: '<App foo=\'bar\' />;',
-     errors: [{message: DEPRECATION_WARNING}], options: ['single'], ecmaFeatures: {jsx: true}},
-    {code: '<App foo="bar" />;',
-     errors: [{message: DEPRECATION_WARNING}], options: ['double'], ecmaFeatures: {jsx: true}},
-    {code: '<App foo="ba\'r" />;',
-     errors: [{message: DEPRECATION_WARNING}], options: ['single', 'avoid-escape'], ecmaFeatures: {jsx: true}},
-    {code: '<App foo=\'ba"r\' />;',
-     errors: [{message: DEPRECATION_WARNING}], options: ['double', 'avoid-escape'], ecmaFeatures: {jsx: true}},
-    {code: '<App>foo</App>;',
-     errors: [{message: DEPRECATION_WARNING}], options: ['single'], ecmaFeatures: {jsx: true}},
     {code: '<App foo="bar" />;',
-     errors: [
-      {message: DEPRECATION_WARNING},
-      {message: SINGLEQUOTE_WARNING}
-     ], options: ['single'], ecmaFeatures: {jsx: true}},
+     errors: [{message: 'JSX attributes must use singlequote.'}], options: ['single'], ecmaFeatures: {jsx: true}},
     {code: '<App foo=\'bar\' />;',
-     errors: [
-      {message: DEPRECATION_WARNING},
-      {message: DOUBLEQUOTE_WARNING}
-     ], options: ['double'], ecmaFeatures: {jsx: true}}
+     errors: [{message: 'JSX attributes must use doublequote.'}], options: ['double'], ecmaFeatures: {jsx: true}}
   ]
 });