Fix case where props were not assigned to the right component (fixes #…

…485)
jsx-eslint · Mar 6, 2016 · d54f1a4 · d54f1a4
1 parent 70cebe4
commit d54f1a4
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/util/Components.js b/lib/util/Components.js
@@ -85,8 +85,8 @@ Components.prototype.list = function() {
     if (!this._list.hasOwnProperty(i) || this._list[i].confidence >= 2) {
       continue;
     }
-    var component;
-    var node;
+    var component = null;
+    var node = null;
     node = this._list[i].node;
     while (!component && node.parent) {
       node = node.parent;

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2006,6 +2006,18 @@ ruleTester.run('prop-types', rule, {
       errors: [{
         message: '\'test\' is missing in props validation'
       }]
+    }, {
+      code: [
+        'const TestComponent = props =>',
+        '  <div onClick={() => props.test()} />',
+        'const mapStateToProps = (_, props) => ({',
+        '  otherProp: props.otherProp,',
+        '})'
+      ].join('\n'),
+      parserOptions: parserOptions,
+      errors: [{
+        message: '\'test\' is missing in props validation'
+      }]
     }
   ]
 });