Rewrite require-render-return tests with template literals

jsx-eslint · Oct 3, 2017 · d5d5e34 · d5d5e34
1 parent 4d62834
commit d5d5e34
Showing 1 changed file with 105 additions and 120 deletions.
diff --git a/tests/lib/rules/require-render-return.js b/tests/lib/rules/require-render-return.js
@@ -30,161 +30,146 @@ const ruleTester = new RuleTester({parserOptions});
 ruleTester.run('require-render-return', rule, {
 
   valid: [{
-    // ES6 class
-    code: [
-      'class Hello extends React.Component {',
-      '  render() {',
-      '    return <div>Hello {this.props.name}</div>;',
-      '  }',
-      '}'
-    ].join('\n')
+    code: `
+      class Hello extends React.Component {
+        render() {
+          return <div>Hello {this.props.name}</div>;
+        }
+      }
+    `
   }, {
-    // ES6 class with render property
-    code: [
-      'class Hello extends React.Component {',
-      '  render = () => {',
-      '    return <div>Hello {this.props.name}</div>;',
-      '  }',
-      '}'
-    ].join('\n'),
+    code: `
+      class Hello extends React.Component {
+        render = () => {
+          return <div>Hello {this.props.name}</div>;
+        }
+      }
+    `,
     parser: 'babel-eslint'
   }, {
-    // ES6 class with render property (implicit return)
-    code: [
-      'class Hello extends React.Component {',
-      '  render = () => (',
-      '    <div>Hello {this.props.name}</div>',
-      '  )',
-      '}'
-    ].join('\n'),
+    code: `
+      class Hello extends React.Component {
+        render = () => (
+          <div>Hello {this.props.name}</div>
+        )
+      }
+    `,
     parser: 'babel-eslint'
   }, {
-    // ES5 class
-    code: [
-      'var Hello = createReactClass({',
-      '  displayName: \'Hello\',',
-      '  render: function() {',
-      '    return <div></div>',
-      '  }',
-      '});'
-    ].join('\n')
+    code: `
+      var Hello = createReactClass({
+        displayName: 'Hello',
+        render: function() {
+          return <div></div>
+        }
+      });
+    `
   }, {
-    // Stateless function
-    code: [
-      'function Hello() {',
-      '  return <div></div>;',
-      '}'
-    ].join('\n')
+    code: `
+      function Hello() {
+        return <div></div>;
+      }
+    `
   }, {
-    // Stateless arrow function
-    code: [
-      'var Hello = () => (',
-      '  <div></div>',
-      ');'
-    ].join('\n'),
+    code: `
+      var Hello = () => (
+        <div></div>
+      );
+    `,
     parser: 'babel-eslint'
   }, {
-    // Return in a switch...case
-    code: [
-      'var Hello = createReactClass({',
-      '  render: function() {',
-      '    switch (this.props.name) {',
-      '      case \'Foo\':',
-      '        return <div>Hello Foo</div>;',
-      '      default:',
-      '        return <div>Hello {this.props.name}</div>;',
-      '    }',
-      '  }',
-      '});'
-    ].join('\n')
+    code: `
+      var Hello = createReactClass({
+        render: function() {
+          switch (this.props.name) {
+            case 'Foo':
+              return <div>Hello Foo</div>;
+            default:
+              return <div>Hello {this.props.name}</div>;
+          }
+        }
+      });
+    `
   }, {
-    // Return in a if...else
-    code: [
-      'var Hello = createReactClass({',
-      '  render: function() {',
-      '    if (this.props.name === \'Foo\') {',
-      '      return <div>Hello Foo</div>;',
-      '    } else {',
-      '      return <div>Hello {this.props.name}</div>;',
-      '    }',
-      '  }',
-      '});'
-    ].join('\n')
+    code: `
+      var Hello = createReactClass({
+        render: function() {
+          if (this.props.name === 'Foo') {
+            return <div>Hello Foo</div>;
+          } else {
+            return <div>Hello {this.props.name}</div>;
+          }
+        }
+      });
+    `
   }, {
-    // Not a React component
-    code: [
-      'class Hello {',
-      '  render() {}',
-      '}'
-    ].join('\n')
+    code: `
+      class Hello {
+        render() {}
+      }
+    `
   }, {
     // ES6 class without a render method
     code: 'class Hello extends React.Component {}'
   }, {
     // ES5 class without a render method
     code: 'var Hello = createReactClass({});'
   }, {
-    // ES5 class with an imported render method
-    code: [
-      'var render = require(\'./render\');',
-      'var Hello = createReactClass({',
-      '  render',
-      '});'
-    ].join('\n')
+    code: `
+      var render = require('./render');
+      var Hello = createReactClass({
+        render
+      });
+    `
   }, {
-    // Invalid render method (but accepted by Babel)
-    code: [
-      'class Foo extends Component {',
-      '  render',
-      '}'
-    ].join('\n'),
+    code: `
+      class Foo extends Component {
+        render
+      }
+    `,
     parser: 'babel-eslint'
   }],
 
   invalid: [{
-    // Missing return in ES5 class
-    code: [
-      'var Hello = createReactClass({',
-      '  displayName: \'Hello\',',
-      '  render: function() {}',
-      '});'
-    ].join('\n'),
+    code: `
+      var Hello = createReactClass({
+        displayName: 'Hello',
+        render: function() {}
+      });
+    `,
     errors: [{
       message: 'Your render method should have return statement'
     }]
   }, {
-    // Missing return in ES6 class
-    code: [
-      'class Hello extends React.Component {',
-      '  render() {} ',
-      '}'
-    ].join('\n'),
+    code: `
+      class Hello extends React.Component {
+        render() {} 
+      }
+    `,
     errors: [{
       message: 'Your render method should have return statement'
     }]
   }, {
-    // Missing return (but one is present in a sub-function)
-    code: [
-      'class Hello extends React.Component {',
-      '  render() {',
-      '    const names = this.props.names.map(function(name) {',
-      '      return <div>{name}</div>',
-      '    });',
-      '  } ',
-      '}'
-    ].join('\n'),
+    code: `
+      class Hello extends React.Component {
+        render() {
+          const names = this.props.names.map(function(name) {
+            return <div>{name}</div>
+          });
+        } 
+      }
+    `,
     errors: [{
       message: 'Your render method should have return statement'
     }]
   }, {
-    // Missing return ES6 class render property
-    code: [
-      'class Hello extends React.Component {',
-      '  render = () => {',
-      '    <div>Hello {this.props.name}</div>',
-      '  }',
-      '}'
-    ].join('\n'),
+    code: `
+      class Hello extends React.Component {
+        render = () => {
+          <div>Hello {this.props.name}</div>
+        }
+      }
+    `,
     parser: 'babel-eslint',
     errors: [{
       message: 'Your render method should have return statement'