sort-comp: enforcing static lifecycle methods order

jsx-eslint · May 14, 2018 · dccccad · dccccad
1 parent 7aa4a03
commit dccccad
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/lib/rules/sort-comp.js b/lib/rules/sort-comp.js
@@ -172,7 +172,7 @@ module.exports = {
         }
       }
 
-      if (method.static) {
+      if (method.static && methodsOrder.indexOf(method.name) === -1) {
         const staticIndex = methodsOrder.indexOf('static-methods');
         if (staticIndex >= 0) {
           indexes.push(staticIndex);

diff --git a/tests/lib/rules/sort-comp.js b/tests/lib/rules/sort-comp.js
@@ -504,6 +504,16 @@ ruleTester.run('sort-comp', rule, {
     ].join('\n'),
     parser: 'babel-eslint',
     errors: [{message: 'render should be placed after displayName'}]
+  }, {
+    // Must validate static lifecycle methods
+    code: [
+      'class Hello extends React.Component {',
+      '  static getDerivedStateFromProps() {}',
+      '  constructor() {}',
+      '}'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    errors: [{message: 'getDerivedStateFromProps should be placed after constructor'}]
   }, {
     // Type Annotations should not be at the top by default
     code: [