[Fix] prop-types: null-check rootNode before calling getScope

jsx-eslint · May 30, 2024 · e27ef81 · e27ef81
1 parent 417e1ca
commit e27ef81
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,11 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 
 ## Unreleased
 
+### Fixed
+* [`prop-types`]: null-check rootNode before calling getScope ([#3762][] @crnhrv)
+
+[#3762]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3762
+
 ## [7.34.2] - 2024.05.24
 
 ### Fixed

diff --git a/lib/util/propTypes.js b/lib/util/propTypes.js
@@ -372,7 +372,8 @@ module.exports = function propTypesInstructions(context, components, utils) {
    */
   function resolveValueForIdentifierNode(node, rootNode, callback) {
     if (
-      node
+      rootNode
+      && node
       && node.type === 'Identifier'
     ) {
       const scope = getScope(context, rootNode);

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -3361,6 +3361,20 @@ ruleTester.run('prop-types', rule, {
       `,
       features: ['ts', 'no-babel'],
     },
+    {
+      code: `
+        import React from "react";
+
+        const returnTypeProp = (someProp: any) => ({ someProp });
+
+        const SomeComponent: React.FunctionComponent<
+          ReturnType<typeof returnTypeProp>
+        > = ({ someProp }) => {
+          return <div>{someProp}</div>;
+        };
+      `,
+      features: ['ts', 'no-babel'],
+    },
     {
       code: `
         export const EuiSuperSelectControl: <T extends string>(
@@ -7840,6 +7854,26 @@ ruleTester.run('prop-types', rule, {
       ],
       features: ['ts', 'no-babel'],
     },
+    {
+      code: `
+        import React from "react";
+
+        const returnTypeProp = (someProp: any) => ({ someProp });
+
+        const SomeComponent: React.FunctionComponent<
+          ReturnType<typeof returnTypeProp>
+        > = ({ someIncorrectProp }) => {
+          return <div>{someProp}</div>;
+        };
+      `,
+      errors: [
+        {
+          messageId: 'missingPropType',
+          data: { name: 'someIncorrectProp' },
+        },
+      ],
+      features: ['ts', 'no-babel'],
+    },
     {
       code: `
         import React from 'react';