Fix prop-types crash when destructuring props with spread only

jsx-eslint · Jun 16, 2016 · e341dfa · e341dfa
1 parent cd5ef2b
commit e341dfa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -540,6 +540,7 @@ module.exports = Components.detect(function(context, components, utils) {
         for (var i = 0, j = node.id.properties.length; i < j; i++) {
           // let {props: {firstname}} = this
           var thisDestructuring = (
+            !hasSpreadOperator(node.id.properties[i]) &&
             (node.id.properties[i].key.name === 'props' || node.id.properties[i].key.value === 'props') &&
             node.id.properties[i].value.type === 'ObjectPattern'
           );

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -1223,6 +1223,15 @@ ruleTester.run('prop-types', rule, {
         'class Something extends Component {}'
       ].join('\n'),
       parser: 'babel-eslint'
+    }, {
+      // Should not find any used props
+      code: [
+        'function Hello(props) {',
+        '  const {...rest} = props;',
+        '  return <div>Hello</div>;',
+        '}'
+      ].join('\n'),
+      parserOptions: parserOptions
     }
   ],