Fix identifier handling in default-props-match-prop-types

jsx-eslint · Aug 11, 2017 · f072966 · f072966
1 parent c98ce02
commit f072966
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/lib/rules/default-props-match-prop-types.js b/lib/rules/default-props-match-prop-types.js
@@ -119,7 +119,7 @@ module.exports = {
         propWrapperFunctions.has(node.callee.name) &&
         node.arguments && node.arguments[0]
       ) {
-        return node.arguments[0];
+        return resolveNodeValue(node.arguments[0]);
       }
       return node;
     }

diff --git a/tests/lib/rules/default-props-match-prop-types.js b/tests/lib/rules/default-props-match-prop-types.js
@@ -783,6 +783,29 @@ ruleTester.run('default-props-match-prop-types', rule, {
         column: 3
       }]
     },
+    {
+      code: [
+        'function MyStatelessComponent({ foo, bar }) {',
+        '  return <div>{foo}{bar}</div>;',
+        '}',
+        'const propTypes = {',
+        '  foo: React.PropTypes.string,',
+        '  bar: React.PropTypes.string.isRequired',
+        '};',
+        'MyStatelessComponent.propTypes = forbidExtraProps(propTypes);',
+        'MyStatelessComponent.defaultProps = {',
+        '  baz: "baz"',
+        '};'
+      ].join('\n'),
+      settings: {
+        propWrapperFunctions: ['forbidExtraProps']
+      },
+      errors: [{
+        message: 'defaultProp "baz" has no corresponding propTypes declaration.',
+        line: 10,
+        column: 3
+      }]
+    },
     {
       code: [
         'function MyStatelessComponent({ foo, bar }) {',