Fix no-comment-textnodes incorrectly catching urls (fixes #664)

jsx-eslint · Jul 8, 2016 · f998882 · f998882
1 parent f235b84
commit f998882
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rules/no-comment-textnodes.js b/lib/rules/no-comment-textnodes.js
@@ -19,7 +19,7 @@ module.exports = function(context) {
 
   return {
     Literal: function(node) {
-      if (/\s*\/(\/|\*)/.test(node.value)) {
+      if (/^\s*\/(\/|\*)/m.test(node.value)) {
         // inside component, e.g. <div>literal</div>
         if (node.parent.type !== 'JSXAttribute' &&
             node.parent.type !== 'JSXExpressionContainer' &&

diff --git a/tests/lib/rules/no-comment-textnodes.js b/tests/lib/rules/no-comment-textnodes.js
@@ -109,6 +109,15 @@ ruleTester.run('jsx-needs-i18n', rule, {
       args: [1],
       parser: 'babel-eslint'
     },
+    {
+      code: [
+        '<strong>',
+        '  &nbsp;https://www.example.com/attachment/download/1',
+        '</strong>'
+      ].join('\n'),
+      args: [1],
+      parser: 'babel-eslint'
+    },
 
     // inside element declarations
     {