[Refactor] extract getTokenBeforeClosingBracket to a file.

jsx-eslint · Nov 7, 2016 · fd51133 · fd51133
1 parent 56846a6
commit fd51133
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 29 deletions.
diff --git a/lib/rules/jsx-space-before-closing.js b/lib/rules/jsx-space-before-closing.js
@@ -4,6 +4,8 @@
  */
 'use strict';
 
+var getTokenBeforeClosingBracket = require('../util/getTokenBeforeClosingBracket');
+
 // ------------------------------------------------------------------------------
 // Rule Definition
 // ------------------------------------------------------------------------------
@@ -30,19 +32,6 @@ module.exports = {
     var NEVER_MESSAGE = 'A space is forbidden before closing bracket';
     var ALWAYS_MESSAGE = 'A space is required before closing bracket';
 
-    /**
-     * Find the token before the closing bracket.
-     * @param {ASTNode} node - The JSX element node.
-     * @returns {Token} The token before the closing bracket.
-     */
-    function getTokenBeforeClosingBracket(node) {
-      var attributes = node.attributes;
-      if (attributes.length === 0) {
-        return node.name;
-      }
-      return attributes[ attributes.length - 1 ];
-    }
-
     // --------------------------------------------------------------------------
     // Public
     // --------------------------------------------------------------------------

diff --git a/lib/rules/jsx-tag-spacing.js b/lib/rules/jsx-tag-spacing.js
@@ -4,22 +4,7 @@
  */
 'use strict';
 
-// ------------------------------------------------------------------------------
-// Helpers
-// ------------------------------------------------------------------------------
-
-/**
- * Find the token before the closing bracket.
- * @param {ASTNode} node - The JSX element node.
- * @returns {Token} The token before the closing bracket.
- */
-function getTokenBeforeClosingBracket(node) {
-  var attributes = node.attributes;
-  if (attributes.length === 0) {
-    return node.name;
-  }
-  return attributes[ attributes.length - 1 ];
-}
+var getTokenBeforeClosingBracket = require('../util/getTokenBeforeClosingBracket');
 
 // ------------------------------------------------------------------------------
 // Validators

diff --git a/lib/util/getTokenBeforeClosingBracket.js b/lib/util/getTokenBeforeClosingBracket.js
@@ -0,0 +1,16 @@
+'use strict';
+
+/**
+ * Find the token before the closing bracket.
+ * @param {ASTNode} node - The JSX element node.
+ * @returns {Token} The token before the closing bracket.
+ */
+function getTokenBeforeClosingBracket(node) {
+  var attributes = node.attributes;
+  if (attributes.length === 0) {
+    return node.name;
+  }
+  return attributes[attributes.length - 1];
+}
+
+module.exports = getTokenBeforeClosingBracket;