Fix jsx-no-target-blank to target only anchor elements

jsx-eslint · Sep 12, 2016 · ffd8ea7 · ffd8ea7
1 parent 79b56b4
commit ffd8ea7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -21,6 +21,10 @@ module.exports = {
   create: function(context) {
     return {
       JSXAttribute: function(node) {
+        if (node.parent.name.name !== 'a') {
+          return;
+        }
+
         if (node.name.name === 'target' && node.value.value === '_blank') {
           var relFound = false;
           var attrs = node.parent.attributes;

diff --git a/tests/lib/rules/jsx-no-target-blank.js b/tests/lib/rules/jsx-no-target-blank.js
@@ -29,7 +29,8 @@ ruleTester.run('jsx-no-target-blank', rule, {
     {code: '<a randomTag></a>', parserOptions: parserOptions},
     {code: '<a href="foobar" target="_blank" rel="noopener noreferrer"></a>', parserOptions: parserOptions},
     {code: '<a target="_blank" {...spreadProps} rel="noopener noreferrer"></a>', parserOptions: parserOptions},
-    {code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions}
+    {code: '<a target="_blank" rel="noopener noreferrer" {...spreadProps}></a>', parserOptions: parserOptions},
+    {code: '<p target="_blank"></p>', parserOptions: parserOptions}
   ],
   invalid: [
     {code: '<a target="_blank"></a>', parserOptions: parserOptions,