-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-literals: only check strings #1301
Labels
Comments
With that option turned off, do you still see the errors? If enabling the option creates new warnings for non-strings, then yes, that's a bug. |
with |
Thanks, that'd be great! |
oh i put the wrong issue # in the commit message -__- |
davidyorr
added a commit
to davidyorr/eslint-plugin-react
that referenced
this issue
Jul 13, 2017
This rule should only check strings. Fixes jsx-eslint#1301
ok i fixed it, let me know if there's anything i need to change |
ljharb
pushed a commit
to davidyorr/eslint-plugin-react
that referenced
this issue
Jul 29, 2017
This rule should only check strings. Fixes jsx-eslint#1301
This was referenced Sep 22, 2018
This was referenced Oct 25, 2018
1 task
1 task
1 task
This was referenced Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
should the no-literals rule check if the
node.value
is a string? with the new{ "noStrings": true }
option (#1202) I'm getting errors for explicitly set boolean and number propsbooleanprop={true}
numberprop={100}
The text was updated successfully, but these errors were encountered: