Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: version check raises undefined error #1790

Closed
LINKIWI opened this issue May 12, 2018 · 2 comments
Closed

Regression: version check raises undefined error #1790

LINKIWI opened this issue May 12, 2018 · 2 comments

Comments

@LINKIWI
Copy link

LINKIWI commented May 12, 2018

Noticed a build failure here: https://travis-ci.org/LINKIWI/orion-web/builds/377922959

Seems to be related to the changeset from #1786; this is the only recent change affecting lib/util/version.js.

$ eslint .
Cannot read property 'split' of undefined
TypeError: Cannot read property 'split' of undefined
    at test (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/util/version.js:30:25)
    at Object.testReactVersion (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/util/version.js:39:10)
    at isDeprecated (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/rules/no-deprecated.js:104:21)
    at checkDeprecation (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/rules/no-deprecated.js:109:12)
    at methods.forEach.method (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/rules/no-deprecated.js:162:35)
    at Array.forEach (<anonymous>)
    at Object.checkLifeCycleMethods (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/rules/no-deprecated.js:162:17)
    at updatedRuleInstructions.(anonymous function) (/home/travis/build/LINKIWI/orion-web/node_modules/eslint-plugin-react/lib/util/Components.js:698:75)
    at listeners.(anonymous function).forEach.listener (/home/travis/build/LINKIWI/orion-web/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
@ljharb
Copy link
Member

ljharb commented May 12, 2018

That build ran with v7.8.0 (see the branch name), the PR you linked and the bugfix it contains is in v7.8.1.

@LINKIWI
Copy link
Author

LINKIWI commented May 12, 2018

You're right; my mistake. I noticed that the 7.8.1 build failed as well but did not check if the failure cause was the same.

@LINKIWI LINKIWI closed this as completed May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants